Merge pull request #115 from revsys/versions-order

Order older versions by release date, descending

versions/tests/fixtures.py

@@ -61,7 +61,7 @@ def old_version(db):
     last_year = datetime.date.today() - datetime.timedelta(days=365)
     v = baker.make(
         "versions.Version",
-        name="Version 1.79.0",
+        name="Version 1.70.0",
         description="Some awesome description of the library",
         release_date=last_year,
     )

versions/tests/test_views.py

@@ -1,3 +1,8 @@
+import datetime
+
+from model_bakery import baker
+
+
 def test_version_list(version, tp):
     """
     GET /versions/
@@ -10,14 +15,22 @@ def test_version_list_context(version, old_version, inactive_version, tp):
     """
     GET /versions/
     """
+    older_version = baker.make(
+        "versions.Version",
+        name="Version 1.67.0",
+        description="Sample",
+        release_date=datetime.date.today() - datetime.timedelta(days=700),
+    )
     res = tp.get("version-list")
     tp.response_200(res)
     assert "current_version" in res.context
     assert "version_list" in res.context
+    assert len(res.context["version_list"]) == 2
     assert res.context["current_version"] == version
     assert old_version in res.context["version_list"]
+    assert older_version in res.context["version_list"]
+    assert old_version == res.context["version_list"][0]
     assert inactive_version not in res.context["version_list"]
-    assert len(res.context["version_list"]) == 1
 
 
 def test_version_detail(version, tp):

versions/views.py

@@ -7,7 +7,7 @@ class VersionList(ListView):
     """Web display of list of Versions"""
 
     model = Version
-    queryset = Version.objects.active()
+    queryset = Version.objects.active().order_by("-release_date")
     template_name = "versions/list.html"
 
     def get_context_data(self):