boost/wave
2
0
Fork 0
mirror of https://github.com/boostorg/wave.git synced 2026-01-19 04:42:16 +00:00
Code Issues Projects Releases Wiki Activity

Clarify loop logic to satisfy a Clang warning

Browse Source 
Clang warns that a for loop in a sample increments an iterator in both
the header and the body. This seems to be done on purpose to skip
whitespace. I used std::advance in the header instead, for clarity.

Also cleaned up an unused type in the same file while I was there.
This commit is contained in:
Jeff Trull
2020-09-24 20:58:15 -07:00
parent 4584e295fc
commit 06c2ca14bf
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
samples/preprocess_pragma_output/preprocess_pragma_output.hpp
View File

@@ -115,7 +115,6 @@ public:
typename Context::token_type const& option,
Container const& values, typename Context::token_type const& act_token)
{
typedef typename Context::token_type token_type;
typedef typename Context::iterator_type iterator_type;
if (option.get_value() == "pp") {
@@ -140,10 +139,10 @@ public:
Container pragma;
iterator_type end = ctx.end();
for (iterator_type it = ctx.begin(s.begin(), s.end());
it != end && token_id(*it) != T_EOF; ++it)
it != end && token_id(*it) != T_EOF;
std::advance(it, 2)) // skip over whitespace
{
pragma.push_back(*it);
it++;
}
// prepend the newly generated token sequence to the 'pending'