boost/filesystem
2
0
Fork 0
mirror of https://github.com/boostorg/filesystem.git synced 2026-01-19 04:12:09 +00:00
Code Issues Projects Releases Wiki Activity

Downgrade dir_iterator implementation on NTE_BAD_SIGNATURE error on Windows.

Browse Source 
This error code is reported to be returned by
GetFileInformationByHandleEx(FileIdExtdDirectoryRestartInfo) in case of
Samba 3.0.2 share accessed from a Windows Server 2019 client, when
RequireSecuritySignature is set to 1 on the client. In the same setup,
GetFileInformationByHandleEx(FileBothDirectoryInformation) is reported
to succeed.

This doesn't seem to reproduce with Samba 4.19 server and Windows 10
client, so it may be specific to the client and server versions, or it
may be something else in the user's setup.

Add NTE_BAD_SIGNATURE to the list of errors on which we non-permanently
downgrade directory_iterator implementation to an older method.

Closes https://github.com/boostorg/filesystem/issues/334.
This commit is contained in:
Andrey Semashev
2025-06-15 17:50:39 +03:00
parent 3420809e37
commit 868dc76bb6
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
doc/release_history.html
View File

@@ -43,6 +43,7 @@
<h2>1.90.0</h2>
<ul>
<li>Clear passed <code>error_code</code> argument on successful completion of the <code>permissions</code> operation. (<a href="https://github.com/boostorg/filesystem/pull/338">PR#338</a>)</li>
<li>On Windows, added a workaround for <code>directory_iterator</code> constructor failing with an "Invalid Signature" error for a Samba 3.0.2 share, when SMB signing is required. (<a href="https://github.com/boostorg/filesystem/issues/334">#334</a>)</li>
</ul>
<h2>1.89.0</h2>

10
src/directory.cpp
View File

@@ -832,19 +832,27 @@ inline bool is_dir_info_class_not_supported(DWORD error)
// GetFileInformationByHandleEx(FileIdExtdDirectoryRestartInfo) return ERROR_INVALID_PARAMETER,
// even though in general the operation is supported by the kernel. SMBv1 returns a special error
// code ERROR_INVALID_LEVEL in this case.
//
// Some other filesystems also don't implement other info classes and return ERROR_INVALID_PARAMETER
// (e.g. see https://github.com/boostorg/filesystem/issues/266), ERROR_GEN_FAILURE, ERROR_INVALID_FUNCTION
// or ERROR_INTERNAL_ERROR (https://github.com/boostorg/filesystem/issues/286). Treat these error codes
// as "non-permanent", even though ERROR_INVALID_PARAMETER is also returned if GetFileInformationByHandleEx
// in general does not support a certain info class. Worst case, we will make extra syscalls on directory
// iterator construction.
//
// Also note that Wine returns ERROR_CALL_NOT_IMPLEMENTED for unimplemented info classes, and
// up until 7.21 it didn't implement FileIdExtdDirectoryRestartInfo and FileFullDirectoryRestartInfo.
// (https://bugs.winehq.org/show_bug.cgi?id=53590)
//
// NTE_BAD_SIGNATURE (0x80090006) is returned from GetFileInformationByHandleEx(FileIdExtdDirectoryInformation)
// for a Samba 3.0.2 share, when RequireSecuritySignature is set to 1 on the Windows Server 2019 client
// (https://github.com/boostorg/filesystem/issues/334). FileBothDirectoryInformation succeeds in this case.
// This doesn't reproduce with Samba 4.19 server and Windows 10 client, so this may be a bug in either
// the client or the server.
return error == ERROR_NOT_SUPPORTED || error == ERROR_INVALID_PARAMETER ||
error == ERROR_INVALID_LEVEL || error == ERROR_CALL_NOT_IMPLEMENTED ||
error == ERROR_GEN_FAILURE || error == ERROR_INVALID_FUNCTION ||
error == ERROR_INTERNAL_ERROR;
error == ERROR_INTERNAL_ERROR || error == NTE_BAD_SIGNATURE;
}
system::error_code dir_itr_create(boost::intrusive_ptr< detail::dir_itr_imp >& imp, fs::path const& dir, directory_options opts, directory_iterator_params* params, fs::path& first_filename, fs::file_status& sf, fs::file_status& symlink_sf)