boost/build
2
0
Fork 0
mirror of https://github.com/boostorg/build.git synced 2026-02-18 01:52:17 +00:00
Code Issues Projects Releases Wiki Activity

win: Increase communication buffers size (#412)

Browse Source 
Currently the size of reading buffer is 16KiB while the the pipe buffer is of
system default size which seems to be 8KiB on Win7. Because of this the half of
the reading buffer is never used.

Also, recent Windows updates with Meltdown mitigation made syscalls more
expensive, and increasing the buffer size will lower the syscalls count.
This commit is contained in:
Nikita Kniazev
2019-03-17 22:10:40 +03:00
committed by Rene Rivera
parent 89b8dbf939
commit 64d292d7a0
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/engine/execnt.c
View File

@@ -112,6 +112,9 @@ static void register_wait( int job_id );
*/
#define MAX_RAW_COMMAND_LENGTH 32766
/* Communication buffers size */
#define IO_BUFFER_SIZE ( 64 * 1024 )
/* We hold handles for pipes used to communicate with child processes in two
* element arrays indexed as follows.
*/
@@ -497,14 +500,14 @@ static void invoke_cmd( char const * const command, int const slot )
/* Create pipes for communicating with the child process. */
if ( !CreatePipe( &cmdtab[ slot ].pipe_out[ EXECCMD_PIPE_READ ],
&cmdtab[ slot ].pipe_out[ EXECCMD_PIPE_WRITE ], &sa, 0 ) )
&cmdtab[ slot ].pipe_out[ EXECCMD_PIPE_WRITE ], &sa, IO_BUFFER_SIZE ) )
{
reportWindowsError( "CreatePipe", slot );
return;
}
if ( globs.pipe_action && !CreatePipe( &cmdtab[ slot ].pipe_err[
EXECCMD_PIPE_READ ], &cmdtab[ slot ].pipe_err[ EXECCMD_PIPE_WRITE ],
&sa, 0 ) )
&sa, IO_BUFFER_SIZE ) )
{
reportWindowsError( "CreatePipe", slot );
return;
@@ -749,8 +752,6 @@ static void record_times( HANDLE const process, timing_info * const time )
}
#define IO_BUFFER_SIZE ( 16 * 1024 )
static char ioBuffer[ IO_BUFFER_SIZE + 1 ];
#define FORWARD_PIPE_NONE 0