mirror of
https://github.com/CLIUtils/CLI11.git
synced 2026-01-19 04:52:08 +00:00
style: run prettier
This commit is contained in:
committed by
Henry Schreiner
parent
3c44bb9fdc
commit
0038ad4658
32
.github/CONTRIBUTING.md
vendored
32
.github/CONTRIBUTING.md
vendored
@@ -8,20 +8,20 @@ Make sure you are comfortable with the license; all contributions are licensed u
|
||||
|
||||
Make sure any new functions you add are are:
|
||||
|
||||
* Documented by `///` documentation for Doxygen
|
||||
* Mentioned in the instructions in the README, though brief mentions are okay
|
||||
* Explained in your PR (or previously explained in an Issue mentioned in the PR)
|
||||
* Completely covered by tests
|
||||
- Documented by `///` documentation for Doxygen
|
||||
- Mentioned in the instructions in the README, though brief mentions are okay
|
||||
- Explained in your PR (or previously explained in an Issue mentioned in the PR)
|
||||
- Completely covered by tests
|
||||
|
||||
In general, make sure the addition is well thought out and does not increase the complexity of CLI11 needlessly.
|
||||
|
||||
## Things you should know
|
||||
|
||||
* Once you make the PR, tests will run to make sure your code works on all supported platforms
|
||||
* The test coverage is also measured, and that should remain 100%
|
||||
* Formatting should be done with pre-commit, otherwise the format check will not pass. However, it is trivial to apply this to your PR, so don't worry about this check. If you do want to run it, see below.
|
||||
* Everything must pass clang-tidy as well, run with `-DCLI11_CLANG_TIDY=ON` (if you set `-DCLI11_CLANG_TIDY_OPTIONS="-fix"`, make sure you use a single threaded build process, or just build one example target).
|
||||
* Your changes must also conform to most of the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html) rules checked by [cpplint](https://github.com/cpplint/cpplint). For unused cpplint filters and justifications, see [CPPLINT.cfg](/CPPLINT.cfg).
|
||||
- Once you make the PR, tests will run to make sure your code works on all supported platforms
|
||||
- The test coverage is also measured, and that should remain 100%
|
||||
- Formatting should be done with pre-commit, otherwise the format check will not pass. However, it is trivial to apply this to your PR, so don't worry about this check. If you do want to run it, see below.
|
||||
- Everything must pass clang-tidy as well, run with `-DCLI11_CLANG_TIDY=ON` (if you set `-DCLI11_CLANG_TIDY_OPTIONS="-fix"`, make sure you use a single threaded build process, or just build one example target).
|
||||
- Your changes must also conform to most of the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html) rules checked by [cpplint](https://github.com/cpplint/cpplint). For unused cpplint filters and justifications, see [CPPLINT.cfg](/CPPLINT.cfg).
|
||||
|
||||
## Pre-commit
|
||||
|
||||
@@ -74,10 +74,10 @@ Remember to replace the emoji in the readme, being careful not to replace the on
|
||||
|
||||
Steps:
|
||||
|
||||
* Update changelog if needed
|
||||
* Update the version in `.appveyor.yml` and `include/CLI/Version.hpp`.
|
||||
* Find and replace in README (new minor/major release only):
|
||||
* Replace " 🆕" and "🆕 " with "" (ignores the description line)
|
||||
* Check for `\/\/$` (vi syntax) to catch leftover `// 🆕`
|
||||
* Replace "🚧" with "🆕" (manually ignore the description line)
|
||||
* Make a release in the GitHub UI, use a name such as "Version X.Y(.Z): Title"
|
||||
- Update changelog if needed
|
||||
- Update the version in `.appveyor.yml` and `include/CLI/Version.hpp`.
|
||||
- Find and replace in README (new minor/major release only):
|
||||
- Replace " 🆕" and "🆕 " with "" (ignores the description line)
|
||||
- Check for `\/\/$` (vi syntax) to catch leftover `// 🆕`
|
||||
- Replace "🚧" with "🆕" (manually ignore the description line)
|
||||
- Make a release in the GitHub UI, use a name such as "Version X.Y(.Z): Title"
|
||||
|
||||
Reference in New Issue
Block a user