From ea283f114a80cb37899a6334ca65381e69c74c0a Mon Sep 17 00:00:00 2001
From: Lacey Williams Henschel <laceynwilliams@gmail.com>
Date: Mon, 13 Feb 2023 12:02:35 -0800
Subject: [PATCH] :wrench: Fixes for library-detail-by-version view

---
 config/urls.py                |  2 +-
 libraries/tests/test_views.py | 20 +++++++++++++++-----
 libraries/views.py            |  2 +-
 3 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/config/urls.py b/config/urls.py
index 867f51ec..53a1ff9a 100755
--- a/config/urls.py
+++ b/config/urls.py
@@ -139,7 +139,7 @@ urlpatterns = [
     path(
         "versions/<slug:version_slug>/libraries/<slug:slug>/",
         LibraryDetailByVersion.as_view(),
-        name="libraries-by-version-detail",
+        name="library-detail-by-version",
     ),
     path(
         "versions/<slug:slug>/libraries/",
diff --git a/libraries/tests/test_views.py b/libraries/tests/test_views.py
index e86167ef..bf13b44b 100644
--- a/libraries/tests/test_views.py
+++ b/libraries/tests/test_views.py
@@ -27,10 +27,10 @@ def test_libraries_by_category(tp, library, category):
 
 
 def test_libraries_by_version_detail(tp, library_version):
-    """GET /versions/{version_identifier}/libraries/{slug}/"""
+    """GET /versions/{version_slug}/libraries/{slug}/"""
     res = tp.get(
-        "libraries-by-version-detail",
-        library_version.version.pk,
+        "library-detail-by-version",
+        library_version.version.slug,
         library_version.library.slug,
     )
     tp.response_200(res)
@@ -40,13 +40,23 @@ def test_libraries_by_version_detail(tp, library_version):
 def test_libraries_by_version_detail_no_library_found(tp, library_version):
     """GET /versions/{version_identifier}/libraries/{slug}/"""
     res = tp.get(
-        "libraries-by-version-detail",
-        library_version.version.pk,
+        "library-detail-by-version",
+        library_version.version.slug,
         "coffee",
     )
     tp.response_404(res)
 
 
+def test_libraries_by_version_detail_no_version_found(tp, library_version):
+    """GET /versions/{version_identifier}/libraries/{slug}/"""
+    res = tp.get(
+        "library-detail-by-version",
+        "coffee",
+        library_version.library.slug,
+    )
+    tp.response_404(res)
+
+
 def test_libraries_by_version(tp, library_version):
     """GET /versions/{version_identifier}/libraries/"""
     # Create a new library_version
diff --git a/libraries/views.py b/libraries/views.py
index 5f9478a0..51406fa6 100644
--- a/libraries/views.py
+++ b/libraries/views.py
@@ -84,7 +84,7 @@ class LibraryDetailByVersion(CategoryMixin, DetailView):
 
         try:
             obj = self.get_queryset().get(slug=slug)
-        except queryset.model.DoesNotExist:
+        except self.model.DoesNotExist:
             raise Http404("No library found matching the query")
         return obj