From ce2727c5ba2e58744390cb394e9fa63f68b104b0 Mon Sep 17 00:00:00 2001 From: Lacey Williams Henschel Date: Mon, 13 Feb 2023 12:21:01 -0800 Subject: [PATCH] :umbrella: Reorder tests --- libraries/tests/test_views.py | 158 +++++++++++++++++----------------- 1 file changed, 81 insertions(+), 77 deletions(-) diff --git a/libraries/tests/test_views.py b/libraries/tests/test_views.py index f86044b5..55448174 100644 --- a/libraries/tests/test_views.py +++ b/libraries/tests/test_views.py @@ -7,83 +7,6 @@ def test_library_list(library, tp): tp.response_200(res) -def test_library_list_select_category(library, category, tp): - """POST /libraries/ to submit a category redirects to the libraries-by-category page""" - res = tp.post("libraries", data={"categories": category.pk}) - tp.response_302(res) - - -def test_library_list_by_category(library_version, category, tp): - """GET /libraries-by-category/{category_slug}/""" - library = library_version.library - version = library_version.version - library.categories.add(category) - res = tp.get("libraries-by-category", category.slug) - tp.response_302(res) - assert res.url == f"/versions/{version.pk}/libraries-by-category/{category.slug}/" - - -def test_libraries_by_version_by_category(tp, library_version, category): - """GET /versions/{version_slug}/libraries-by-category/{slug}/""" - library = library_version.library - version = library_version.version - - baker.make("libraries.Library", name="Sample") - library.categories.add(category) - res = tp.get("libraries-by-version-by-category", version.pk, category.slug) - tp.response_200(res) - assert "library_list" in res.context - assert len(res.context["library_list"]) == 1 - assert library in res.context["library_list"] - assert "category" in res.context - assert res.context["category"] == category - - -def test_libraries_by_version_detail(tp, library_version): - """GET /versions/{version_slug}/libraries/{slug}/""" - res = tp.get( - "library-detail-by-version", - library_version.version.slug, - library_version.library.slug, - ) - tp.response_200(res) - assert "version" in res.context - - -def test_libraries_by_version_detail_no_library_found(tp, library_version): - """GET /versions/{version_identifier}/libraries/{slug}/""" - res = tp.get( - "library-detail-by-version", - library_version.version.slug, - "coffee", - ) - tp.response_404(res) - - -def test_libraries_by_version_detail_no_version_found(tp, library_version): - """GET /versions/{version_identifier}/libraries/{slug}/""" - res = tp.get( - "library-detail-by-version", - "coffee", - library_version.library.slug, - ) - tp.response_404(res) - - -def test_libraries_by_version_list(tp, library_version): - """GET /versions/{version_slug}/libraries/""" - # Create a new library_version - excluded_library = baker.make("libraries.Library", name="Sample") - res = tp.get("libraries-by-version", library_version.version.slug) - tp.response_200(res) - assert "library_list" in res.context - - # Confirm that correct libraries are present - assert len(res.context["library_list"]) == 1 - assert library_version.library in res.context["library_list"] - assert excluded_library not in res.context["library_list"] - - def test_library_detail(library, tp): """GET /libraries/{repo}/""" url = tp.reverse("library-detail", library.slug) @@ -125,3 +48,84 @@ def test_library_detail_context_get_open_issues_count(tp, library): assert "open_issues_count" in response.context # Verify that the count only includes the one open issue for this library assert response.context["open_issues_count"] == 1 + + +def test_library_list_select_category(library, category, tp): + """POST /libraries/ to submit a category redirects to the libraries-by-category page""" + res = tp.post("libraries", data={"categories": category.pk}) + tp.response_302(res) + + +def test_library_list_by_category(library_version, category, tp): + """GET /libraries-by-category/{category_slug}/""" + library = library_version.library + baker.make("libraries.Library", name="Sample") + library.categories.add(category) + res = tp.get("libraries-by-category", category.slug) + tp.response_200(res) + assert "library_list" in res.context + assert len(res.context["library_list"]) == 1 + assert library in res.context["library_list"] + assert "category" in res.context + assert res.context["category"] == category + + +def test_libraries_by_version_by_category(tp, library_version, category): + """GET /versions/{version_slug}/libraries-by-category/{slug}/""" + library = library_version.library + version = library_version.version + + baker.make("libraries.Library", name="Sample") + library.categories.add(category) + res = tp.get("libraries-by-version-by-category", version.slug, category.slug) + tp.response_200(res) + assert "library_list" in res.context + assert len(res.context["library_list"]) == 1 + assert library in res.context["library_list"] + assert "category" in res.context + assert res.context["category"] == category + + +def test_libraries_by_version_list(tp, library_version): + """GET /versions/{version_slug}/libraries/""" + # Create a new library_version + excluded_library = baker.make("libraries.Library", name="Sample") + res = tp.get("libraries-by-version", library_version.version.slug) + tp.response_200(res) + assert "library_list" in res.context + + # Confirm that correct libraries are present + assert len(res.context["library_list"]) == 1 + assert library_version.library in res.context["library_list"] + assert excluded_library not in res.context["library_list"] + + +def test_libraries_by_version_detail(tp, library_version): + """GET /versions/{version_slug}/libraries/{slug}/""" + res = tp.get( + "library-detail-by-version", + library_version.version.slug, + library_version.library.slug, + ) + tp.response_200(res) + assert "version" in res.context + + +def test_libraries_by_version_detail_no_library_found(tp, library_version): + """GET /versions/{version_identifier}/libraries/{slug}/""" + res = tp.get( + "library-detail-by-version", + library_version.version.slug, + "coffee", + ) + tp.response_404(res) + + +def test_libraries_by_version_detail_no_version_found(tp, library_version): + """GET /versions/{version_identifier}/libraries/{slug}/""" + res = tp.get( + "library-detail-by-version", + "coffee", + library_version.library.slug, + ) + tp.response_404(res)