From 255eec701bd76ea290ff0235353c9155ae0c89fa Mon Sep 17 00:00:00 2001
From: Greg Newman <greg@gregnewman.org>
Date: Wed, 5 Jul 2023 10:31:22 -0400
Subject: [PATCH] :art: adds label to form fields
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Don’t use placeholder as labels. That’s confusing.
---
 static/css/styles.css               | 8 ++++----
 templates/includes/_form_input.html | 5 ++++-
 templates/news/_entry_form.html     | 2 ++
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/static/css/styles.css b/static/css/styles.css
index 0d3fb971..3203e7da 100644
--- a/static/css/styles.css
+++ b/static/css/styles.css
@@ -3021,6 +3021,10 @@ input[type=file] {
     margin-bottom: 1.5rem;
   }
 
+  .md\:mr-5 {
+    margin-right: 1.25rem;
+  }
+
   .md\:ml-6 {
     margin-left: 1.5rem;
   }
@@ -3029,10 +3033,6 @@ input[type=file] {
     margin-left: 1.25rem;
   }
 
-  .md\:mr-5 {
-    margin-right: 1.25rem;
-  }
-
   .md\:block {
     display: block;
   }
diff --git a/templates/includes/_form_input.html b/templates/includes/_form_input.html
index 915eeef5..613a73e2 100644
--- a/templates/includes/_form_input.html
+++ b/templates/includes/_form_input.html
@@ -2,6 +2,8 @@
 {% load widget_tweaks %}
 
 
+<label>{{ field.label }}
+
 {% if field.errors %}
   {% for error in field.errors %}
   <div class="py-1 px-3 text-white bg-red-600">
@@ -13,5 +15,6 @@
 {% if field.field.widget.input_type == "file" %}
   {% render_field field class="text-sm text-grey-500 !border-0 file:mr-5 file:py-2 file:px-6 file:rounded-lg file:border-0 file:text-sm file:font-medium file:bg-white file:text-slate hover:file:cursor-pointer hover:file:bg-orange hover:file:text-white" placeholder=field.label %}
 {% else %}
-  {% render_field field class="w-full bg-white rounded border-gray-300 dark:text-white text-slate dark:border-slate dark:bg-charcoal" placeholder=field.label %}
+  {% render_field field class="w-full bg-white rounded border-gray-300 dark:text-white text-slate dark:border-slate dark:bg-charcoal" %}
 {% endif %}
+</label>
diff --git a/templates/news/_entry_form.html b/templates/news/_entry_form.html
index 6a45599b..74a17409 100644
--- a/templates/news/_entry_form.html
+++ b/templates/news/_entry_form.html
@@ -5,7 +5,9 @@
 
   <div class="space-y-3">
   {% for field in form.visible_fields %}
+    <div>
     {% include "includes/_form_input.html" with form=form field=field %}
+    </div>
   {% endfor %}
   </div>