diff --git a/config/urls.py b/config/urls.py index 71d3c408..9f4c9666 100755 --- a/config/urls.py +++ b/config/urls.py @@ -72,6 +72,11 @@ urlpatterns = [ TemplateView.as_view(template_name="review/upcoming_reviews.html"), name="review-upcoming", ), + path( + "review/detail/", + TemplateView.as_view(template_name="review/review_detail.html"), + name="review-request", + ), path( "review/", TemplateView.as_view(template_name="review/review_process.html"), diff --git a/frontend/styles.css b/frontend/styles.css index ca7d036a..a8bf621c 100644 --- a/frontend/styles.css +++ b/frontend/styles.css @@ -21,6 +21,9 @@ body { h4 { @apply text-xl; } + h5 { + @apply text-base + } p { @apply py-5; } diff --git a/static/css/styles.css b/static/css/styles.css index 246fa3fe..b53aa85e 100644 --- a/static/css/styles.css +++ b/static/css/styles.css @@ -572,6 +572,10 @@ select { h4 { font-size: 1.25rem; line-height: 1.75rem; +} + h5 { + font-size: 1rem; + line-height: 1.5rem; } p { padding-top: 1.25rem; @@ -851,6 +855,12 @@ select { .mt-0 { margin-top: 0px; } +.mt-6 { + margin-top: 1.5rem; +} +.ml-5 { + margin-left: 1.25rem; +} .block { display: block; } @@ -1041,11 +1051,6 @@ select { margin-top: calc(1.5rem * calc(1 - var(--tw-space-y-reverse))); margin-bottom: calc(1.5rem * var(--tw-space-y-reverse)); } -.space-x-8 > :not([hidden]) ~ :not([hidden]) { - --tw-space-x-reverse: 0; - margin-right: calc(2rem * var(--tw-space-x-reverse)); - margin-left: calc(2rem * calc(1 - var(--tw-space-x-reverse))); -} .space-x-11 > :not([hidden]) ~ :not([hidden]) { --tw-space-x-reverse: 0; margin-right: calc(2.75rem * var(--tw-space-x-reverse)); @@ -1087,12 +1092,6 @@ select { .border-t { border-top-width: 1px; } -.border-l { - border-left-width: 1px; -} -.border-r { - border-right-width: 1px; -} .border-orange { --tw-border-opacity: 1; border-color: rgb(255 159 0 / var(--tw-border-opacity)); @@ -1223,6 +1222,10 @@ select { padding-top: 4rem; padding-bottom: 4rem; } +.py-8 { + padding-top: 2rem; + padding-bottom: 2rem; +} .pr-2 { padding-right: 0.5rem; } @@ -1292,6 +1295,9 @@ select { .pr-11 { padding-right: 2.75rem; } +.pt-16 { + padding-top: 4rem; +} .text-left { text-align: left; } @@ -1347,9 +1353,6 @@ select { .capitalize { text-transform: capitalize; } -.leading-10 { - line-height: 2.5rem; -} .tracking-tight { letter-spacing: -0.025em; } diff --git a/templates/review/review_detail.html b/templates/review/review_detail.html new file mode 100644 index 00000000..45534577 --- /dev/null +++ b/templates/review/review_detail.html @@ -0,0 +1,171 @@ +{% extends "base.html" %} + +{% load static %} + +{% block subnav %} +
+ Review Process + Submit Review + Upcoming Reviews + Past Reviews +
+{% endblock %} + +{% block content %} +
+
+ +
+
+ +
+

Lambda2

+

Review Dates: March 22, 2021 - March 31, 2021

+
+ +
+
Accepted: 4
+
Conditional Accepted: 1
+
Reject: 1
+
+ +
+ +
+
+
Accepted
+

+ There was initially a single reject, but was later changed to Conditional Accept with the condition that: +

+
    +
  • Lambda2 provides its own placeholders instead of importing the standard ones.
    • +
+ +

+ The review discussion touched on these pros and cons: +

+ +

Pros:

+
    +
  • It's simple, clean, and elegant.
    • +
  • lightweight, single header dependency
    • +
  • Involves less typing
    • +
+ +

Cons:

+
    +
  • lambda and phoenix library have much larger functionality
    • +
  • For complex lambda expressions, native C++ lambdas are more "future-proof" + than boost::lambda2 expressions because you have the full range of the language available.
    • +
  • Having to write using-declarations for each operator in each scope that they + are intended to be used defeats the purpose.
    • +
+ + +

In the end, the pros outweighed the cons.

+ +

There was also the concern that boost::lambda2 does not and cannot do short-circuiting + of the && and || operators. I suggest writing a rationale and make it clear in the + documentation. I think this is a major flaw. +

+ +

But the most glaring issue has to do with ADL: That Boost.Lambda2 defines the operators + that should belong to namespace std::placeholders. Hence, the condition that Lambda2 + provides its own placeholders instead of importing the standard ones. +

+ +

+ There were also a couple of suggested improvements. I'll leave that up to Peter to + decide whether to implement or not, since these suggestions are not conditions + for acceptance. +

+ +

+ Again, thank you very much everyone, and thank you Peter for submitting this + splendid library. +

+ +

+ Regards,
+ Joel +

+ +
+ +
+
Pending
+

+ The Boost formal review of the Lambda2, authored by Peter Dimov, starts Monday, March 22, 2021 to March 31, 2021 (inclusive). +

+ +

Documentation: https://pdimov.github.io/lambda2/doc/html/lambda2.html
+ Source: https://github.com/pdimov/lambda2/ +

+ +

+ Lambda2 is a simple, but functional, C++14 lambda library. It takes advantage + of the fact that the standard  header already provides placeholders + _1, _2, _3, and so on, for use with std::bind, and function objects such + as std::plus, std::greater, std::logical_not, and std::bit_xor, corresponding to + arithmetic, relational, logical and bitwise operators. +

+ +

+ Please provide in your review information you think is valuable to + understand your choice to ACCEPT or REJECT including Lambda2 as a + Boost library. Please be explicit about your decision (ACCEPT or REJECT). +

+ +

+ Some other questions you might want to consider answering: +

+ +
    +
  • What is your evaluation of the design?
    • +
  • What is your evaluation of the implementation?
    • +
  • What is your evaluation of the documentation?
    • +
  • What is your evaluation of the potential usefulness of the library?
    • +
  • Did you try to use the library? With which compiler(s)? Did you + have any problems?
    • +
  • How much effort did you put into your evaluation? A glance? A quick + reading? In-depth study?
    • +
  • Are you knowledgeable about the problem domain?
    • +
+ +

+ More information about the Boost Formal Review Process can be found + at http://www.boost.org/reviews +

+ +

+ The review is open to anyone who is prepared to put in the work of + evaluating and reviewing the library. Prior experience in contributing to + Boost reviews is not a requirement. +

+ +

+ Thank you for your efforts in the Boost community. They are very much + appreciated. +

+ +

+ Peter is often available in the CppLang Slack #boost channel should you + require any clarification not covered by the documentation. I am not frequently + available in the Slack channel, but I'll certainly pay attention to the discussions. + Please don't hesitate to ping me if needed. +

+ +

+ Cheers,
+ Joel de Guzman +

+
+
+
+ +
+{% endblock %}