boost/python
2
0
Fork 0
mirror of https://github.com/boostorg/python.git synced 2026-01-21 05:02:17 +00:00
Code Issues Projects Releases Wiki Activity

Use strong reference APIs.

Browse Source 
For the free-threaded build, it is not safe use borrowed references.
Another thread could deallocate the object and cause the reference to
become invalid.  Replace API calls that borrow references with strong
reference APIs.
This commit is contained in:
Neil Schemenauer
2025-10-13 20:59:57 -07:00
parent 97402f7925
commit cabb466057
3 changed files with 35 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/wrapper.cpp
View File

@@ -21,20 +21,28 @@ namespace detail
this->m_self, const_cast<char*>(name))))
)
{
PyObject* borrowed_f = 0;
PyObject* class_f = 0;
if (
PyMethod_Check(m.get())
&& PyMethod_GET_SELF(m.get()) == this->m_self
&& class_object->tp_dict != 0
)
{
borrowed_f = ::PyDict_GetItemString(
#if PY_VERSION_HEX >= 0x030D0000
if (::PyDict_GetItemStringRef(
class_object->tp_dict, const_cast<char*>(name), &class_f) < 0) {
throw_error_already_set();
}
#else
class_f = ::PyDict_GetItemString(
class_object->tp_dict, const_cast<char*>(name));
Py_XINCREF(class_f);
#endif
}
if (borrowed_f != PyMethod_GET_FUNCTION(m.get()))
bool is_override = (class_f != PyMethod_GET_FUNCTION(m.get()));
Py_XDECREF(class_f);
if (is_override)
return override(m);
}
}