diff --git a/boost/numeric/odeint/integrate/detail/integrate_adaptive.hpp b/boost/numeric/odeint/integrate/detail/integrate_adaptive.hpp index 071159f7..ebbe9e90 100644 --- a/boost/numeric/odeint/integrate/detail/integrate_adaptive.hpp +++ b/boost/numeric/odeint/integrate/detail/integrate_adaptive.hpp @@ -56,12 +56,14 @@ size_t integrate_adaptive( { size_t steps = detail::integrate_const( stepper , system , start_state , start_time , end_time , dt , observer , stepper_tag() ); + typename odeint::unwrap_reference< Observer >::type &obs = observer; + typename odeint::unwrap_reference< Stepper >::type &st = stepper; + Time end = start_time + dt*steps; if( less_with_sign( end , end_time , dt ) ) { //make a last step to end exactly at end_time - stepper.do_step( system , start_state , end , end_time - end ); + st.do_step( system , start_state , end , end_time - end ); steps++; - typename odeint::unwrap_reference< Observer >::type &obs = observer; obs( start_state , end_time ); } return steps; @@ -79,6 +81,7 @@ size_t integrate_adaptive( ) { typename odeint::unwrap_reference< Observer >::type &obs = observer; + typename odeint::unwrap_reference< Stepper >::type &st = stepper; const size_t max_attempts = 1000; const char *error_string = "Integrate adaptive : Maximal number of iterations reached. A step size could not be found."; @@ -95,7 +98,7 @@ size_t integrate_adaptive( controlled_step_result res = success; do { - res = stepper.try_step( system , start_state , start_time , dt ); + res = st.try_step( system , start_state , start_time , dt ); ++trials; } while( ( res == fail ) && ( trials < max_attempts ) ); @@ -120,25 +123,27 @@ size_t integrate_adaptive( Observer observer , dense_output_stepper_tag ) { typename odeint::unwrap_reference< Observer >::type &obs = observer; + typename odeint::unwrap_reference< Stepper >::type &st = stepper; size_t count = 0; - stepper.initialize( start_state , start_time , dt ); + st.initialize( start_state , start_time , dt ); - while( less_with_sign( stepper.current_time() , end_time , stepper.current_time_step() ) ) + while( less_with_sign( st.current_time() , end_time , st.current_time_step() ) ) { - while( less_eq_with_sign( stepper.current_time() + stepper.current_time_step() , + while( less_eq_with_sign( st.current_time() + st.current_time_step() , end_time , - stepper.current_time_step() ) ) + st.current_time_step() ) ) { //make sure we don't go beyond the end_time - obs( stepper.current_state() , stepper.current_time() ); - stepper.do_step( system ); + obs( st.current_state() , st.current_time() ); + st.do_step( system ); ++count; } - stepper.initialize( stepper.current_state() , stepper.current_time() , end_time - stepper.current_time() ); + // calculate time step to arrive exactly at end time + st.initialize( st.current_state() , st.current_time() , end_time - st.current_time() ); } - obs( stepper.current_state() , stepper.current_time() ); + obs( st.current_state() , st.current_time() ); // overwrite start_state with the final point - boost::numeric::odeint::copy( stepper.current_state() , start_state ); + boost::numeric::odeint::copy( st.current_state() , start_state ); return count; } diff --git a/boost/numeric/odeint/integrate/detail/integrate_const.hpp b/boost/numeric/odeint/integrate/detail/integrate_const.hpp index 2eb7ae0a..534f60b9 100644 --- a/boost/numeric/odeint/integrate/detail/integrate_const.hpp +++ b/boost/numeric/odeint/integrate/detail/integrate_const.hpp @@ -46,6 +46,7 @@ size_t integrate_const( ) { typename odeint::unwrap_reference< Observer >::type &obs = observer; + typename odeint::unwrap_reference< Stepper >::type &st = stepper; Time time = start_time; int step = 0; @@ -53,7 +54,7 @@ size_t integrate_const( while( less_eq_with_sign( time+dt , end_time , dt ) ) { obs( start_state , time ); - stepper.do_step( system , start_state , time , dt ); + st.do_step( system , start_state , time , dt ); // direct computation of the time avoids error propagation happening when using time += dt // we need clumsy type analysis to get boost units working here ++step; @@ -103,10 +104,11 @@ size_t integrate_const( ) { typename odeint::unwrap_reference< Observer >::type &obs = observer; + typename odeint::unwrap_reference< Stepper >::type &st = stepper; Time time = start_time; - stepper.initialize( start_state , time , dt ); + st.initialize( start_state , time , dt ); obs( start_state , time ); time += dt; @@ -115,9 +117,9 @@ size_t integrate_const( while( less_with_sign( time+dt , end_time , dt ) ) { - while( less_eq_with_sign( time , stepper.current_time() , dt ) ) + while( less_eq_with_sign( time , st.current_time() , dt ) ) { - stepper.calc_state( time , start_state ); + st.calc_state( time , start_state ); obs( start_state , time ); ++obs_step; // direct computation of the time avoids error propagation happening when using time += dt @@ -125,20 +127,20 @@ size_t integrate_const( time = start_time + static_cast< typename unit_value_type