From 2bea451ac8debb55de3b78a4ce30a960c2247947 Mon Sep 17 00:00:00 2001
From: jzmaddock <john@johnmaddock.co.uk>
Date: Fri, 31 May 2024 18:57:37 +0100
Subject: [PATCH] Correct conceptual failings, remove tests which can't
 possibly succeed.

---
 include/boost/math/distributions/non_central_t.hpp | 4 ++--
 test/exp_sinh_quadrature_test.cpp                  | 1 -
 test/tanh_sinh_quadrature_test.cpp                 | 2 --
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/include/boost/math/distributions/non_central_t.hpp b/include/boost/math/distributions/non_central_t.hpp
index d3d58cd20..a6c988d75 100644
--- a/include/boost/math/distributions/non_central_t.hpp
+++ b/include/boost/math/distributions/non_central_t.hpp
@@ -424,10 +424,10 @@ namespace boost
             // We only call this routine when we know that the series form of 1F1 is cheap to evaluate,
             // so no need to call the whole 1F1 function, just the series will do:
             //
-            T Av = hypergeometric_1F1_generic_series((v + 1) / 2, boost::math::constants::half<T>(), mu * mu * x * x / (2 * (x * x + v)), pol, scale, function);
+            T Av = hypergeometric_1F1_generic_series(static_cast<T>((v + 1) / 2), boost::math::constants::half<T>(), static_cast<T>(mu * mu * x * x / (2 * (x * x + v))), pol, scale, function);
             Av = ldexp(Av, static_cast<int>(scale));
             scale = 0;
-            T Bv = hypergeometric_1F1_generic_series(v / 2 + T(1), T(3) / 2, mu * mu * x * x / (2 * (x * x + v)), pol, scale, function);
+            T Bv = hypergeometric_1F1_generic_series(static_cast<T>(v / 2 + T(1)), static_cast<T>(T(3) / 2), static_cast<T>(mu * mu * x * x / (2 * (x * x + v))), pol, scale, function);
             Bv = ldexp(Bv, static_cast<int>(scale));
             Bv *= boost::math::tgamma_delta_ratio(v / 2 + T(1), -constants::half<T>(), pol);
             Bv *= boost::math::constants::root_two<T>() * mu * x / sqrt(x * x + v);
diff --git a/test/exp_sinh_quadrature_test.cpp b/test/exp_sinh_quadrature_test.cpp
index 7c958d5d8..7bba2298a 100644
--- a/test/exp_sinh_quadrature_test.cpp
+++ b/test/exp_sinh_quadrature_test.cpp
@@ -670,7 +670,6 @@ BOOST_AUTO_TEST_CASE(exp_sinh_quadrature_test)
     test_right_limit_infinite<cpp_bin_float_quad>();
     test_nr_examples<cpp_bin_float_quad>();
     test_crc<cpp_bin_float_quad>();
-    test_non_central_t<cpp_bin_float_quad>();
 #endif
 
 #if !defined(BOOST_MATH_NO_LONG_DOUBLE_MATH_FUNCTIONS) && !defined(BOOST_MATH_NO_REAL_CONCEPT_TESTS)
diff --git a/test/tanh_sinh_quadrature_test.cpp b/test/tanh_sinh_quadrature_test.cpp
index 534abfdfa..ffd55352b 100644
--- a/test/tanh_sinh_quadrature_test.cpp
+++ b/test/tanh_sinh_quadrature_test.cpp
@@ -1028,7 +1028,6 @@ BOOST_AUTO_TEST_CASE(tanh_sinh_quadrature_test)
     test_crc<cpp_bin_float_quad>();
     test_sf<cpp_bin_float_quad>();
     test_2_arg<cpp_bin_float_quad>();
-    test_non_central_t<cpp_bin_float_quad>();
 #endif
 #endif
 #ifdef TEST5
@@ -1083,7 +1082,6 @@ BOOST_AUTO_TEST_CASE(tanh_sinh_quadrature_test)
     test_crc<boost::multiprecision::float128>();
     test_sf<boost::multiprecision::float128>();
     test_2_arg<boost::multiprecision::float128>();
-    test_non_central_t<boost::multiprecision::float128>();
 
 #endif
 #ifdef TEST9