From b5ad3186c8ea6e7ccb1a68f689ac37718648562c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20=C5=81oskot?= Date: Wed, 12 Dec 2018 20:47:02 +0100 Subject: [PATCH] [cmake] Explain removal of default /W3 flag [ci skip] --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9b80dc7c3..d73dd6226 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -154,6 +154,7 @@ if(GIL_BUILD_IO) target_link_libraries(gil_dependencies INTERFACE ${_tiffxx_library}) + target_include_directories(gil_dependencies INTERFACE ${_tiffxx_include_dir}) @@ -185,6 +186,7 @@ endif() add_library(gil_compile_options INTERFACE) target_compile_features(gil_compile_options INTERFACE cxx_std_11) +# see https://cmake.org/pipermail/cmake/2018-December/068716.html if(MSVC) string(REGEX REPLACE "/W3" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) string(REGEX REPLACE "-W3" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})