Compare commits

...

10 Commits

Author SHA1 Message Date
Peter Dimov
53c084084d Use BOOST_TEST_TRAIT_SAME 2022-12-23 02:32:03 +02:00
Peter Dimov
c225007399 Update dependency list in cmake_subdir_test 2022-12-23 02:17:32 +02:00
Peter Dimov
4633220a9d Update ci.yml 2022-12-23 02:14:27 +02:00
Peter Dimov
16fca8368b Keep -Wmaybe-uninitialized disabled 2022-05-30 20:25:13 +03:00
Peter Dimov
4cf7c718b8 Merge branch 'gcc12-Wuninitialized' of https://github.com/jngrad/boost-function into feature/issue-42 2022-05-30 19:56:08 +03:00
Peter Dimov
389f886bc3 Add test for issue #42 2022-05-30 19:36:29 +03:00
Peter Dimov
abc1bf9b4a Extend GCC 11 workaround to GCC 12 as well 2022-05-30 18:44:07 +03:00
Peter Dimov
e665d1e9af Disable -Wdeprecated-declarations for GCC 12 2022-05-30 18:18:09 +03:00
Peter Dimov
f7e42dc08f Update ci.yml 2022-05-30 17:35:22 +03:00
Jean-Noël Grad
5b4e2797a2 Avoid -Wuninitialized warnings in GCC 12 2022-05-30 16:16:41 +02:00
8 changed files with 96 additions and 34 deletions

View File

@@ -20,33 +20,48 @@ jobs:
- toolset: gcc-4.8 - toolset: gcc-4.8
cxxstd: "03,11" cxxstd: "03,11"
os: ubuntu-18.04 os: ubuntu-18.04
install: g++-4.8 install: g++-4.8-multilib
address-model: 32,64
- toolset: gcc-5 - toolset: gcc-5
cxxstd: "03,11,14,1z" cxxstd: "03,11,14,1z"
os: ubuntu-18.04 os: ubuntu-18.04
install: g++-5 install: g++-5-multilib
address-model: 32,64
- toolset: gcc-6 - toolset: gcc-6
cxxstd: "03,11,14,1z" cxxstd: "03,11,14,1z"
os: ubuntu-18.04 os: ubuntu-18.04
install: g++-6 install: g++-6-multilib
address-model: 32,64
- toolset: gcc-7 - toolset: gcc-7
cxxstd: "03,11,14,17" cxxstd: "03,11,14,17"
os: ubuntu-18.04 os: ubuntu-18.04
install: g++-7-multilib
address-model: 32,64
- toolset: gcc-8 - toolset: gcc-8
cxxstd: "03,11,14,17,2a" cxxstd: "03,11,14,17,2a"
os: ubuntu-18.04 os: ubuntu-18.04
install: g++-8 install: g++-8-multilib
address-model: 32,64
- toolset: gcc-9 - toolset: gcc-9
cxxstd: "03,11,14,17,2a" cxxstd: "03,11,14,17,2a"
os: ubuntu-20.04 os: ubuntu-20.04
install: g++-9-multilib
address-model: 32,64
- toolset: gcc-10 - toolset: gcc-10
cxxstd: "03,11,14,17,2a" cxxstd: "03,11,14,17,2a"
os: ubuntu-20.04 os: ubuntu-20.04
install: g++-10 install: g++-10-multilib
address-model: 32,64
- toolset: gcc-11 - toolset: gcc-11
cxxstd: "03,11,14,17,2a" cxxstd: "03,11,14,17,20"
os: ubuntu-20.04 os: ubuntu-20.04
install: g++-11 install: g++-11-multilib
address-model: 32,64
- toolset: gcc-12
cxxstd: "03,11,14,17,20"
os: ubuntu-22.04
install: g++-12-multilib
address-model: 32,64
- toolset: clang - toolset: clang
compiler: clang++-3.9 compiler: clang++-3.9
cxxstd: "03,11,14" cxxstd: "03,11,14"
@@ -92,8 +107,18 @@ jobs:
os: ubuntu-20.04 os: ubuntu-20.04
- toolset: clang - toolset: clang
compiler: clang++-12 compiler: clang++-12
cxxstd: "03,11,14,17,2a" cxxstd: "03,11,14,17,20"
os: ubuntu-20.04 os: ubuntu-20.04
- toolset: clang
compiler: clang++-13
cxxstd: "03,11,14,17,20"
os: ubuntu-22.04
install: clang-13
- toolset: clang
compiler: clang++-14
cxxstd: "03,11,14,17,20"
os: ubuntu-22.04
install: clang-14
- toolset: clang - toolset: clang
cxxstd: "03,11,14,17,2a" cxxstd: "03,11,14,17,2a"
os: macos-10.15 os: macos-10.15
@@ -101,7 +126,7 @@ jobs:
runs-on: ${{matrix.os}} runs-on: ${{matrix.os}}
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v3
- name: Install packages - name: Install packages
if: matrix.install if: matrix.install
@@ -137,7 +162,8 @@ jobs:
- name: Run tests - name: Run tests
run: | run: |
cd ../boost-root cd ../boost-root
./b2 -j3 libs/$LIBRARY/test toolset=${{matrix.toolset}} cxxstd=${{matrix.cxxstd}} variant=debug,release export ADDRMD=${{matrix.address-model}}
./b2 -j3 libs/$LIBRARY/test toolset=${{matrix.toolset}} cxxstd=${{matrix.cxxstd}} ${ADDRMD:+address-model=$ADDRMD} variant=debug,release
windows: windows:
strategy: strategy:
@@ -145,18 +171,18 @@ jobs:
matrix: matrix:
include: include:
- toolset: msvc-14.0 - toolset: msvc-14.0
cxxstd: "14" cxxstd: 14,latest
addrmd: 32,64 addrmd: 32,64
os: windows-2019 os: windows-2019
- toolset: msvc-14.1
cxxstd: "14,17,latest"
addrmd: 32,64
os: windows-2016
- toolset: msvc-14.2 - toolset: msvc-14.2
cxxstd: "14,17,latest" cxxstd: "14,17,20,latest"
addrmd: 32,64 addrmd: 32,64
os: windows-2019 os: windows-2019
- toolset: msvc-14.3 - toolset: msvc-14.3
cxxstd: "14,17,20,latest"
addrmd: 32,64
os: windows-2022
- toolset: clang-win
cxxstd: "14,17,latest" cxxstd: "14,17,latest"
addrmd: 32,64 addrmd: 32,64
os: windows-2022 os: windows-2022
@@ -168,7 +194,7 @@ jobs:
runs-on: ${{matrix.os}} runs-on: ${{matrix.os}}
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v3
- name: Setup Boost - name: Setup Boost
shell: cmd shell: cmd
@@ -196,7 +222,7 @@ jobs:
shell: cmd shell: cmd
run: | run: |
cd ../boost-root cd ../boost-root
b2 -j3 libs/%LIBRARY%/test toolset=${{matrix.toolset}} cxxstd=${{matrix.cxxstd}} address-model=${{matrix.addrmd}} variant=debug,release b2 -j3 libs/%LIBRARY%/test toolset=${{matrix.toolset}} cxxstd=${{matrix.cxxstd}} address-model=${{matrix.addrmd}} variant=debug,release embed-manifest-via=linker
posix-cmake-subdir: posix-cmake-subdir:
strategy: strategy:
@@ -210,7 +236,7 @@ jobs:
runs-on: ${{matrix.os}} runs-on: ${{matrix.os}}
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v3
- name: Install packages - name: Install packages
if: matrix.install if: matrix.install
@@ -256,7 +282,7 @@ jobs:
runs-on: ${{matrix.os}} runs-on: ${{matrix.os}}
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v3
- name: Install packages - name: Install packages
if: matrix.install if: matrix.install
@@ -312,7 +338,7 @@ jobs:
runs-on: ${{matrix.os}} runs-on: ${{matrix.os}}
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v3
- name: Install packages - name: Install packages
if: matrix.install if: matrix.install

View File

@@ -906,6 +906,10 @@ namespace boost {
// This warning is technically correct, but we don't want to pay the price for initializing // This warning is technically correct, but we don't want to pay the price for initializing
// just to silence a warning: https://github.com/boostorg/function/issues/27 // just to silence a warning: https://github.com/boostorg/function/issues/27
# pragma GCC diagnostic ignored "-Wmaybe-uninitialized" # pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
# if (BOOST_GCC >= 120000)
// GCC 12 emits a different warning: https://github.com/boostorg/function/issues/42
# pragma GCC diagnostic ignored "-Wuninitialized"
# endif
# endif # endif
std::memcpy(this->functor.data, f.functor.data, sizeof(boost::detail::function::function_buffer)); std::memcpy(this->functor.data, f.functor.data, sizeof(boost::detail::function::function_buffer));
# if defined(BOOST_GCC) && (BOOST_GCC >= 40700) # if defined(BOOST_GCC) && (BOOST_GCC >= 40700)
@@ -1004,20 +1008,24 @@ namespace boost {
// This warning is technically correct, but we don't want to pay the price for initializing // This warning is technically correct, but we don't want to pay the price for initializing
// just to silence a warning: https://github.com/boostorg/function/issues/27 // just to silence a warning: https://github.com/boostorg/function/issues/27
# pragma GCC diagnostic ignored "-Wmaybe-uninitialized" # pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
# if (BOOST_GCC >= 120000)
// GCC 12 emits a different warning: https://github.com/boostorg/function/issues/42
# pragma GCC diagnostic ignored "-Wuninitialized"
# endif
# endif # endif
std::memcpy(this->functor.data, f.functor.data, sizeof(this->functor.data)); std::memcpy(this->functor.data, f.functor.data, sizeof(this->functor.data));
# if defined(BOOST_GCC) && (BOOST_GCC >= 40700) # if defined(BOOST_GCC) && (BOOST_GCC >= 40700)
# pragma GCC diagnostic pop # pragma GCC diagnostic pop
# endif # endif
} else } else
#if defined(BOOST_GCC) && (__GNUC__ == 11) #if defined(BOOST_GCC) && (__GNUC__ >= 11)
# pragma GCC diagnostic push # pragma GCC diagnostic push
// False positive in GCC 11 for empty function objects (function_n_test.cpp:673) // False positive in GCC 11/12 for empty function objects (function_n_test.cpp:673)
# pragma GCC diagnostic ignored "-Wmaybe-uninitialized" # pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif #endif
get_vtable()->base.manager(f.functor, this->functor, get_vtable()->base.manager(f.functor, this->functor,
boost::detail::function::move_functor_tag); boost::detail::function::move_functor_tag);
#if defined(BOOST_GCC) && (__GNUC__ == 11) #if defined(BOOST_GCC) && (__GNUC__ >= 11)
# pragma GCC diagnostic pop # pragma GCC diagnostic pop
#endif #endif
f.vtable = 0; f.vtable = 0;

View File

@@ -82,3 +82,5 @@ run test_return_function.cpp return_function/<cxxstd>14 : : : <link>shared $(che
run test_return_function.cpp return_function/<cxxstd>14 : : : <link>static $(check14) : return_function_static_14 ; run test_return_function.cpp return_function/<cxxstd>14 : : : <link>static $(check14) : return_function_static_14 ;
run quick.cpp ; run quick.cpp ;
compile issue_42.cpp ;

View File

@@ -33,10 +33,8 @@ boost_add_subdir(typeof)
boost_add_subdir(static_assert) boost_add_subdir(static_assert)
boost_add_subdir(container_hash) boost_add_subdir(container_hash)
boost_add_subdir(smart_ptr) boost_add_subdir(describe)
boost_add_subdir(detail) boost_add_subdir(mp11)
boost_add_subdir(move)
boost_add_subdir(predef)
# --target check # --target check

21
test/issue_42.cpp Normal file
View File

@@ -0,0 +1,21 @@
// Copyright 2022 Peter Dimov.
// Distributed under the Boost Software License, Version 1.0.
// https://www.boost.org/LICENSE_1_0.txt
//
// https://github.com/boostorg/function/issues/42
#include <boost/function.hpp>
struct F
{
int operator()( int x ) const { return -x; }
};
struct X
{
boost::function<int(int)> f_;
explicit X( boost::function<int(int)> f ): f_( f ) {}
};
F f2;
X x( f2 ); // -Wuninitialized under GCC 12

View File

@@ -8,7 +8,6 @@
// http://www.boost.org/LICENSE_1_0.txt) // http://www.boost.org/LICENSE_1_0.txt)
#include <boost/function.hpp> #include <boost/function.hpp>
#include <boost/core/is_same.hpp>
#include <boost/core/lightweight_test_trait.hpp> #include <boost/core/lightweight_test_trait.hpp>
struct X struct X
@@ -27,14 +26,14 @@ int main()
{ {
typedef boost::function<X(Y)> F1; typedef boost::function<X(Y)> F1;
BOOST_TEST_TRAIT_TRUE(( boost::core::is_same<F1::result_type, X> )); BOOST_TEST_TRAIT_SAME(F1::result_type, X);
BOOST_TEST_TRAIT_TRUE(( boost::core::is_same<F1::argument_type, Y> )); BOOST_TEST_TRAIT_SAME(F1::argument_type, Y);
typedef boost::function<X(Y, Z)> F2; typedef boost::function<X(Y, Z)> F2;
BOOST_TEST_TRAIT_TRUE(( boost::core::is_same<F2::result_type, X> )); BOOST_TEST_TRAIT_SAME(F2::result_type, X);
BOOST_TEST_TRAIT_TRUE(( boost::core::is_same<F2::first_argument_type, Y> )); BOOST_TEST_TRAIT_SAME(F2::first_argument_type, Y);
BOOST_TEST_TRAIT_TRUE(( boost::core::is_same<F2::second_argument_type, Z> )); BOOST_TEST_TRAIT_SAME(F2::second_argument_type, Z);
return boost::report_errors(); return boost::report_errors();
} }

View File

@@ -14,6 +14,10 @@
# endif # endif
#endif #endif
#if defined(__GNUC__) && __GNUC__ >= 12
# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
#include <boost/function.hpp> #include <boost/function.hpp>
#include <iostream> #include <iostream>
#include <functional> #include <functional>

View File

@@ -14,6 +14,10 @@
# endif # endif
#endif #endif
#if defined(__GNUC__) && __GNUC__ >= 12
# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
#include <boost/function.hpp> #include <boost/function.hpp>
#include <iostream> #include <iostream>
#include <functional> #include <functional>