build

mirror of https://github.com/boostorg/build.git synced 2026-02-15 00:52:16 +00:00

Files

Steven Watanabe acdf27398b Remove premature optimization that breaks piecemeal on windows.

The bug happens because exec_check replaces the shell inside
the command structure, but make1cmds retains a reference to
the old shell. The bug appears when all of the following are true:
- The action is piecemeal
- b2 is running on Windows
- SHELL is %
- The action contains elements that require a shell
- The action is split into multiple commands
In particular, this applies for gcc.archive with a large
number of object files.

Instead of attempting to reuse the same shell, we make
a new copy in every iteration of the loop.  The shell
and target lists are usually short and the cost of copying
them is insignificant compared to the other work done by the loop.
In addition, the optimization is rarely triggered because
piecemeal actions that require splitting are relatively rare.

2019-02-15 11:55:59 -07:00